[ 
https://issues.apache.org/jira/browse/YARN-3471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494992#comment-14494992
 ] 

Zhijie Shen commented on YARN-3471:
-----------------------------------

bq. makes sense in v1 as people can misconfigure their URL.

In v1, when we initialize the client, it will print the url, which won't change 
during the lifecycle of the client.

bq. I'd like to see this patch (or variant thereof) in branch-2

This patch mainly focus on reusing TimelineClientConnectionRetry for v2 APIs to 
only retry on connect exception, while it fix some related problems of 
TimelineClientConnectionRetry.

But I agree that we can have a jira to fix TimelineClientConnectionRetry 
generally on trunk/branch-2.


> Fix timeline client retry
> -------------------------
>
>                 Key: YARN-3471
>                 URL: https://issues.apache.org/jira/browse/YARN-3471
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-3471.1.patch, YARN-3471.2.patch
>
>
> I found that the client retry has some problems:
> 1. The new put methods will retry on all exception, but they should only do 
> it upon ConnectException.
> 2. We can reuse TimelineClientConnectionRetry to simplify the retry logic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to