Robert Kanter commented on YARN-3046:

I think something that really hasn't been properly discussed is how compatible 
the ATS v1 APIs are with the v2 APIs, or how aware the user needs to be about 
which ATS they are using.  (We're running into that in the other direction in 

Here's some more specific comments about the patch:
# In this message, {code}LOG.error("putEntityNonBlocking get failed: " + 
This isn't a GET call, so it should just say {{"putEntityNonBlocking failed: " 
+ e}}
# Why not set the TimelineEvent Id in the {{toTimelineEvent()}} methods (or a 
parent method)?
# Given that all of the {{toTimelineEvent()}} methods are copy-paste of the 
switch statement in {{JobHistoryEventHandler#processEventForTimelineServer()}}, 
can you refactor processEventForTimelineServer() to use the 
{{toTimelineEvent()}} methods instead?  That's a cleaner way of doing this and 
it's getting the same information.  I know this is used by ATS v1, but we can 
still clean it up; especially given that it's all copy-pasted here anyway.

> [Event producers] Implement MapReduce AM writing some MR metrics to ATS
> -----------------------------------------------------------------------
>                 Key: YARN-3046
>                 URL: https://issues.apache.org/jira/browse/YARN-3046
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Junping Du
>         Attachments: YARN-3046-no-test-v2.patch, YARN-3046-no-test.patch, 
> YARN-3046-v1-rebase.patch, YARN-3046-v1.patch
> Per design in YARN-2928, select a handful of MR metrics (e.g. HDFS bytes 
> written) and have the MR AM write the framework-specific metrics to ATS.

This message was sent by Atlassian JIRA

Reply via email to