[ 
https://issues.apache.org/jira/browse/YARN-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495151#comment-14495151
 ] 

Naganarasimha G R commented on YARN-3390:
-----------------------------------------

Thanks for the patch [~zjshen], As earlier mentioned in Yarn-3044 if we go 
ahead with the notion that RM will be aware of RMCollector(manager) through 
RMcontext then in future if we want to segregate the dependencies b/w RM and 
Timeline service projects again need to do the changes in the core part 
(RMAppImpl and Resourcemanager), If the dependencies are fine then approach 
looks fine to me . 
Alternative way to avoid dependency is invoking RMTimelineCollectorManager's 
{{putIfAbsent()}} and {{remove(ApplicationId appId)}}  when SMP needs to 
publish publishApplicationCreatedEvent and publishApplicationFinishedEvent. In 
the approach what i have taken in Yarn-3044, RMTimelineCollector(can be renamed 
to TimelineServiceV2Publisher which will be responsible for publishing v2 
events) can  invoke RMTimelineCollectorManager's {{putIfAbsent()}} and 
{{remove(ApplicationId appId)}}.

> Reuse TimelineCollectorManager for RM
> -------------------------------------
>
>                 Key: YARN-3390
>                 URL: https://issues.apache.org/jira/browse/YARN-3390
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-3390.1.patch
>
>
> RMTimelineCollector should have the context info of each app whose entity  
> has been put



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to