[ https://issues.apache.org/jira/browse/YARN-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14496306#comment-14496306 ]
Hudson commented on YARN-3266: ------------------------------ FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #165 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/165/]) YARN-3266. RMContext#inactiveNodes should have NodeId as map key. Contributed by Chengbing Liu (jianhe: rev b46ee1e7a31007985b88072d9af3d97c33a261a7) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebApp.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMActiveServiceContext.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java * hadoop-yarn-project/CHANGES.txt > RMContext inactiveNodes should have NodeId as map key > ----------------------------------------------------- > > Key: YARN-3266 > URL: https://issues.apache.org/jira/browse/YARN-3266 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Affects Versions: 2.6.0 > Reporter: Chengbing Liu > Assignee: Chengbing Liu > Fix For: 2.8.0 > > Attachments: YARN-3266.01.patch, YARN-3266.02.patch, > YARN-3266.03.patch > > > Under the default NM port configuration, which is 0, we have observed in the > current version, "lost nodes" count is greater than the length of the lost > node list. This will happen when we consecutively restart the same NM twice: > * NM started at port 10001 > * NM restarted at port 10002 > * NM restarted at port 10003 > * NM:10001 timeout, {{ClusterMetrics#incrNumLostNMs()}}, # lost node=1; > {{rmNode.context.getInactiveRMNodes().put(rmNode.nodeId.getHost(), rmNode)}}, > {{inactiveNodes}} has 1 element > * NM:10002 timeout, {{ClusterMetrics#incrNumLostNMs()}}, # lost node=2; > {{rmNode.context.getInactiveRMNodes().put(rmNode.nodeId.getHost(), rmNode)}}, > {{inactiveNodes}} still has 1 element > Since we allow multiple NodeManagers on one host (as discussed in YARN-1888), > {{inactiveNodes}} should be of type {{ConcurrentMap<NodeId, RMNode>}}. If > this will break the current API, then the key string should include the NM's > port as well. > Thoughts? -- This message was sent by Atlassian JIRA (v6.3.4#6332)