Craig Welch commented on YARN-3463:

bq. should we make pendingApplications to use customized comparator
No, applications still start as they did before,  no reason to change it

bq. can we make it not use generic type now for simpler
No, this comes from the interface definition and it's needed to enable another 
scheduler, say FS, be able to use the same code with their derived application 
types of choice

bq. I think we may carefully add ORDERING_POLICY_CONFIG, since this will be a 
public config. I understand the reason to add the policy_config is to support 
policy=fair, config=fair+fifo usecase
So this configuration is not for defining the policy, that is "ORDERING_POLICY" 
(which is where you would have "fair", "fifo", etc), this is for configuration 
elements which may modify the behavior of the policy, such as sizeBasedWeight, 
& it's needed for that purpose.

bq. Why change disposableLeafQueue.getApplications().size()
I think this is left over from earlier changes & is no longer needed, will 

bq. Suppress generic warning? Javac warning?
I'm actually not getting any there, I think because this is used for mocking

> Integrate OrderingPolicy Framework with CapacityScheduler
> ---------------------------------------------------------
>                 Key: YARN-3463
>                 URL: https://issues.apache.org/jira/browse/YARN-3463
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Craig Welch
>            Assignee: Craig Welch
>         Attachments: YARN-3463.50.patch, YARN-3463.61.patch, 
> YARN-3463.64.patch, YARN-3463.65.patch, YARN-3463.66.patch
> Integrate the OrderingPolicy Framework with the CapacityScheduler

This message was sent by Atlassian JIRA

Reply via email to