[
https://issues.apache.org/jira/browse/YARN-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498752#comment-14498752
]
Xuan Gong commented on YARN-1402:
---------------------------------
bq. if only one container (other containers haven't report for some reasons,
e.g. pending on scheduled by RM) has a report to RM which completed, we
shouldn't mark log aggregation as completed for this app. We should check app's
status also?
Good point. We should check whether the app is at the final state or not, too
bq. Shall we return app's LA status still as running even some node LA (log
aggregation) report already get failed. I don't think app's LA status can
finish successfully later in this case. So may be return failed earlier could
be a good choice?
Change LogAggregationStatus.FINISHED to LogAggregationStatus.SUCCEEDED.
For my understand, FAILED and SUCCEEDED are the final state. It means that the
log aggregation is stopped. Based on whether the aggregated logs are completed
or in-completed, we will give either FAILED or SUCCEEDED.
bq. I think a better way to generate app's log aggregation status is not when
do get() but when each node's LA report do update (in method of
aggregateLogReport()). What do you think?
No need to do it. We only call getLogAggregationStatusForAppReport() if needed.
> Related Web UI, CLI changes on exposing client API to check log aggregation
> status
> ----------------------------------------------------------------------------------
>
> Key: YARN-1402
> URL: https://issues.apache.org/jira/browse/YARN-1402
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-1402.1.patch, YARN-1402.2.patch, YARN-1402.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
