Li Lu commented on YARN-3390:

I skimmed through both patches. The two patches got significant overlap. 
Personally I'd incline to focus on YARN-3437 for now since it's critical to 
writer performance benchmark, which will further block the writer 
implementations. Writer implementation is on our critical path now to deliver 
an end-to-end preview of timeline v2. Therefore I'd prefer to give 3437 higher 
priority for now

For the code, are there any special reasons why ConcurrentHashMap's 
fine-grained locking is not sufficient for collector manager? I think it may 
always be attractive to use finer-grained locking if we do not need strong 
consistency semantics, like snapshot or iterations. 

> Reuse TimelineCollectorManager for RM
> -------------------------------------
>                 Key: YARN-3390
>                 URL: https://issues.apache.org/jira/browse/YARN-3390
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-3390.1.patch
> RMTimelineCollector should have the context info of each app whose entity  
> has been put

This message was sent by Atlassian JIRA

Reply via email to