Craig Welch commented on YARN-3463:

bq. ... I think we can just initialize this.comparator and 
this.schedulableEntities inside FifoOrderingPolicy constructor and remove the 
setComparator method 


bq. this should be inside the {removed} ...


bq. getStatusMessage -> getInfo ?

Originally, it was getInfo - 

I have to say I prefer getInfo to getStatusMessage myself, as getStatusMessage 
suggests to me a transient nature which may change (metrics, etc), whereas this 
is information about policy type and configuration which is effectively static, 
it is just generic info, and isn't particularly transient

If you feel strongly that it should be getInfo, let me know and I'll change it 

> Integrate OrderingPolicy Framework with CapacityScheduler
> ---------------------------------------------------------
>                 Key: YARN-3463
>                 URL: https://issues.apache.org/jira/browse/YARN-3463
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Craig Welch
>            Assignee: Craig Welch
>         Attachments: YARN-3463.50.patch, YARN-3463.61.patch, 
> YARN-3463.64.patch, YARN-3463.65.patch, YARN-3463.66.patch, 
> YARN-3463.67.patch, YARN-3463.68.patch, YARN-3463.69.patch
> Integrate the OrderingPolicy Framework with the CapacityScheduler

This message was sent by Atlassian JIRA

Reply via email to