[
https://issues.apache.org/jira/browse/YARN-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503425#comment-14503425
]
Sangjin Lee commented on YARN-3431:
-----------------------------------
Thanks for the update [~zjshen]! I quickly went over it, and have some comments.
(FlowEntity.java)
- l.58-60: setId() is done twice?
- l. 94: why create a new Long()?
(HierarchicalTimelineEntity.java)
- l.24: I think this was pointed out previously, but I understand the Hadoop
coding convention is not to use wildcard imports
- l.43: wondering out loud, is there an issue in storing the Identifier
directly as opposed to a concenated string? At least, I think we could provide
Identifier.toString() and Identifier.fromString() (static) to handle this more
tersely
> Sub resources of timeline entity needs to be passed to a separate endpoint.
> ---------------------------------------------------------------------------
>
> Key: YARN-3431
> URL: https://issues.apache.org/jira/browse/YARN-3431
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Zhijie Shen
> Assignee: Zhijie Shen
> Attachments: YARN-3431.1.patch, YARN-3431.2.patch, YARN-3431.3.patch,
> YARN-3431.4.patch
>
>
> We have TimelineEntity and some other entities as subclass that inherit from
> it. However, we only have a single endpoint, which consume TimelineEntity
> rather than sub-classes and this endpoint will check the incoming request
> body contains exactly TimelineEntity object. However, the json data which is
> serialized from sub-class object seems not to be treated as an TimelineEntity
> object, and won't be deserialized into the corresponding sub-class object
> which cause deserialization failure as some discussions in YARN-3334 :
> https://issues.apache.org/jira/browse/YARN-3334?focusedCommentId=14391059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14391059.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
