[ 
https://issues.apache.org/jira/browse/YARN-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503751#comment-14503751
 ] 

Jian He commented on YARN-3494:
-------------------------------

Rohith, thanks for working on this !
couple comments:
- remove below ?
{code}
stats.setReservedVCores(getMetrics().getAMResourceLimitMB());

stats.setReservedVCores(getMetrics().getAMResourceLimitVCores());

stats.setReservedVCores(getMetrics().getUsedAMResourceMB());

stats.setReservedVCores(getMetrics().getUsedAMResourceVCores());

stats.setReservedVCores(getMetrics().getUserAMResourceLimitMB());

stats.setReservedVCores(getMetrics().getUserAMResourceLimitVCores());
{code}
- usedAMResource for a given user seems not updated. Existing code re-uses the 
QueueMetrics for userMetrics. Following that, we may not need separate 
userAMResourceLimitMB/userAMResourceLimitVCores, we can use the 
AMResourceLimitMB and AMResourceLimitVCores

> Expose AM resource limit and user limit in QueueMetrics 
> --------------------------------------------------------
>
>                 Key: YARN-3494
>                 URL: https://issues.apache.org/jira/browse/YARN-3494
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Jian He
>            Assignee: Rohith
>         Attachments: 0001-YARN-3494.patch
>
>
> Now we have the AM resource limit and user limit shown on the web UI, it 
> would be useful to expose them in the QueueMetrics as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to