[ 
https://issues.apache.org/jira/browse/YARN-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503792#comment-14503792
 ] 

Wangda Tan commented on YARN-2740:
----------------------------------

Hi [~Naganarasimha],
After reread our conversation, I felt I misled you cause a typo: {{I think it's 
better now prevent admin remove clusterNodeLabel when distributed enabled.}}, 
{{now}} should be {{not}}. I suggest not to prevent removing clusterNodeLabel 
while distributed enabled. The reason is what I mentioned above.
bq. I think it's not a big problem, NM doesn't need to know "x" being removed, 
the logic should be, NM reports label, and RM allocate according to label, NM 
should just move on if adding label failed as what we done in YARN-2495. My 
opinion here is not add extra RM->NM communicate.
Sorry for that.

bq. based on this i mentioned RM->NM communicate/notify would be required as 
labels are sent only on change in NM side and it will not be able show that 
there is error in reporting labels. In btw have raised new jira YARN-3506 for 
this error handling reported in YARN-2495
This may not be a big issue, I suggest to keep it as-is temporarily since it 
needs change NM/RM interface. We can address other issues before come to the 
problem.

Thoughts?

> ResourceManager side should properly handle node label modifications when 
> distributed node label configuration enabled
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2740
>                 URL: https://issues.apache.org/jira/browse/YARN-2740
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>             Fix For: 2.8.0
>
>         Attachments: YARN-2740-20141024-1.patch, YARN-2740.20150320-1.patch, 
> YARN-2740.20150327-1.patch, YARN-2740.20150411-1.patch, 
> YARN-2740.20150411-2.patch, YARN-2740.20150411-3.patch, 
> YARN-2740.20150417-1.patch, YARN-2740.20150420-1.patch
>
>
> According to YARN-2495, when distributed node label configuration is enabled:
> - RMAdmin / REST API should reject change labels on node operations.
> - CommonNodeLabelsManager shouldn't persist labels on nodes when NM do 
> heartbeat.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to