Zhijie Shen commented on YARN-3046:

Hopefully we can agree the scope of this jira to add ATS v2 integration 
side-by-side to v1 (in addition to the fix of TASK_ATTEMPT_ENTITY, which we 
missed in v1).

+1 for the latest patch except two nits:

1. createXXXXEntity's comments need to be updated to reflect the latest code 

2. The following code does nothing, and can be removed.
        1117          // Handle job events
1118          case JOB_SUBMITTED:
1119          case JOB_STATUS_CHANGED:
1120          case JOB_INFO_CHANGED:
1121          case JOB_INITED:
1122          case JOB_PRIORITY_CHANGED:
1123          case JOB_QUEUE_CHANGED:
1124          case JOB_FAILED:
1125          case JOB_KILLED:
1126          case JOB_ERROR:
1127          case JOB_FINISHED:
1128          case AM_STARTED:
1129          case NORMALIZED_RESOURCE:
1130            break;

[~sjlee0], any comment on the last patch?

> [Event producers] Implement MapReduce AM writing MR events to v2 ATS
> --------------------------------------------------------------------
>                 Key: YARN-3046
>                 URL: https://issues.apache.org/jira/browse/YARN-3046
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Junping Du
>         Attachments: YARN-3046-no-test-v2.patch, YARN-3046-no-test.patch, 
> YARN-3046-v1-rebase.patch, YARN-3046-v1.patch, YARN-3046-v2.patch, 
> YARN-3046-v3.patch, YARN-3046-v4.patch, YARN-3046-v5.patch
> Per design in YARN-2928, select a handful of MR metrics (e.g. HDFS bytes 
> written) and have the MR AM write the framework-specific metrics to ATS.

This message was sent by Atlassian JIRA

Reply via email to