[ https://issues.apache.org/jira/browse/YARN-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504164#comment-14504164 ]
Hadoop QA commented on YARN-2498: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726728/YARN-2498.2.patch against trunk revision 44872b7. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 5 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7412//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7412//console This message is automatically generated. > Respect labels in preemption policy of capacity scheduler for inter-queue > preemption > ------------------------------------------------------------------------------------ > > Key: YARN-2498 > URL: https://issues.apache.org/jira/browse/YARN-2498 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Wangda Tan > Assignee: Wangda Tan > Attachments: STALED-YARN-2498.zip, YARN-2498.1.patch, > YARN-2498.2.patch > > > There're 3 stages in ProportionalCapacityPreemptionPolicy, > # Recursively calculate {{ideal_assigned}} for queue. This is depends on > available resource, resource used/pending in each queue and guaranteed > capacity of each queue. > # Mark to-be preempted containers: For each over-satisfied queue, it will > mark some containers will be preempted. > # Notify scheduler about to-be preempted container. > We need respect labels in the cluster for both #1 and #2: > For #1, when calculating ideal_assigned for each queue, we need get > by-partition-ideal-assigned according to queue's > guaranteed/maximum/used/pending resource on specific partition. > For #2, when we make decision about whether we need preempt a container, we > need make sure, resource this container is *possibly* usable by a queue which > is under-satisfied and has pending resource. > In addition, we need to handle ignore_partition_exclusivity case, when we > need to preempt containers from a queue's partition, we will first preempt > ignore_partition_exclusivity allocated containers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)