Junping Du commented on YARN-3046:

Thanks [~zjshen] and [~sjlee0] for review and comments!
bq. createXXXXEntity's comments need to be updated to reflect the latest code 
Nice catch! Updated in v6 patch.

bq. The following code does nothing, and can be removed.
The only thing it does is get rid of falling into default (for unrecognized 
event) where it will be return directly. Let's keep it here.

bq.  OK, this is another existing bug I'll leave it up to you to decide whether 
we want to fix this in ATS v.1 in a separate JIRA.
Let's fix in refactor patch (MAPREDUCE-6318) given we already roll back a 
prefix tiny bug on v1.

bq. I.150: same issue
Good catch! Fix it in v6 patch.

> [Event producers] Implement MapReduce AM writing MR events to v2 ATS
> --------------------------------------------------------------------
>                 Key: YARN-3046
>                 URL: https://issues.apache.org/jira/browse/YARN-3046
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Junping Du
>         Attachments: YARN-3046-no-test-v2.patch, YARN-3046-no-test.patch, 
> YARN-3046-v1-rebase.patch, YARN-3046-v1.patch, YARN-3046-v2.patch, 
> YARN-3046-v3.patch, YARN-3046-v4.patch, YARN-3046-v5.patch
> Per design in YARN-2928, select a handful of MR metrics (e.g. HDFS bytes 
> written) and have the MR AM write the framework-specific metrics to ATS.

This message was sent by Atlassian JIRA

Reply via email to