[ 
https://issues.apache.org/jira/browse/YARN-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Vasudev updated YARN-3517:
--------------------------------
    Attachment: YARN-3517.002.patch

Uploaded a new patch to address Thomas's comments.

bq. Could you also change it to not show the button if you aren't an admin?

Fixed.

{quote}
One other thing is could you add some css or something to make it look more 
like a button. Right now it just looks like text and I didn't know it was 
clickable at first. The placement of it seems a bit weird to me also but as 
along as its only showing up for admins that is less of an issue.
{quote}

I've added some style elements to make it look better.

{quote}
I haven't looked at the patch if details but I see we are creating a new 
AdminACLsManager each time. It would be nice if we didn't have to do that.
{quote}

Fixed.


> RM web ui for dumping scheduler logs should be for admins only
> --------------------------------------------------------------
>
>                 Key: YARN-3517
>                 URL: https://issues.apache.org/jira/browse/YARN-3517
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager, security
>    Affects Versions: 2.7.0
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>              Labels: security
>         Attachments: YARN-3517.001.patch, YARN-3517.002.patch
>
>
> YARN-3294 allows users to dump scheduler logs from the web UI. This should be 
> for admins only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to