[
https://issues.apache.org/jira/browse/YARN-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505193#comment-14505193
]
Sunil G commented on YARN-3517:
-------------------------------
HI [~vvasudev]
I have couple of comments on same..
1.
{code}
+ if (callerUGI != null && adminACLsManager.isAdmin(callerUGI)) {
+ isAdmin = true;
+ }
{code}
If adminACLsManager.areACLsEnabled() is false, do we need above check?
2. a minor nit
{code}.append(" b = confirm(\"Are you sure you wish to generate"{code}
Can be changed as "Are you sure to generate"
> RM web ui for dumping scheduler logs should be for admins only
> --------------------------------------------------------------
>
> Key: YARN-3517
> URL: https://issues.apache.org/jira/browse/YARN-3517
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager, security
> Affects Versions: 2.7.0
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Labels: security
> Attachments: YARN-3517.001.patch, YARN-3517.002.patch
>
>
> YARN-3294 allows users to dump scheduler logs from the web UI. This should be
> for admins only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
