Wangda Tan updated YARN-3413:
    Attachment: YARN-3413.3.patch

Thanks for review, [~vinodkv]:
bq. We should simply force the labelName to follow a ( ) block - i.e. anything 
next to a comma upto the left parenthesis is a label. Right?
I think we need to support both, if we enforce this, it will be a imcompatible 

Other comments are all addressed.

In addition:
- Make GetClusterNodeLabelResponse returns NodeLabel instead of String.
- Filed YARN-3521 to track REST API changes.

> Node label attributes (like exclusivity) should settable via 
> addToClusterNodeLabels but shouldn't be changeable at runtime
> --------------------------------------------------------------------------------------------------------------------------
>                 Key: YARN-3413
>                 URL: https://issues.apache.org/jira/browse/YARN-3413
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-3413.1.patch, YARN-3413.2.patch, YARN-3413.3.patch
> As mentioned in : 
> https://issues.apache.org/jira/browse/YARN-3345?focusedCommentId=14384947&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14384947.
> Changing node label exclusivity and/or other attributes may not be a real use 
> case, and also we should support setting node label attributes whiling adding 
> them to cluster.

This message was sent by Atlassian JIRA

Reply via email to