Naganarasimha G R commented on YARN-2740:

Thanks for the comment [~wangda] 
bq. 2) It's better to cover remove label case since remove label = remove label 
in the cluster + remove label in nodes, add a test to make sure it works in 
distributed mode, same as TestRMAdminService/TestRMWebServicesNodeLabels.
IIUC you want {{prevent removing clusterNodeLabel while distributed enabled}} 
and add test cases for it  ?
bq. 3) RMWebServices.replaceLabelsOnNode(s) should be merged to avoid we need 
to maintain both.
I dont mind working on it here but 2 queries
* Is it that we should still support existing 2 rest api's for 
replaceLabelsOnNode on a single node and other for multiple nodes and ensure 
the common part is extracted to a new method ?
* I understand that it will make it easy for committer to limit number of 
checkins but Is it good in terms of maintainability to include code changes in 
the patch which is not related to this jira description ?

> ResourceManager side should properly handle node label modifications when 
> distributed node label configuration enabled
> ----------------------------------------------------------------------------------------------------------------------
>                 Key: YARN-2740
>                 URL: https://issues.apache.org/jira/browse/YARN-2740
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>             Fix For: 2.8.0
>         Attachments: YARN-2740-20141024-1.patch, YARN-2740.20150320-1.patch, 
> YARN-2740.20150327-1.patch, YARN-2740.20150411-1.patch, 
> YARN-2740.20150411-2.patch, YARN-2740.20150411-3.patch, 
> YARN-2740.20150417-1.patch, YARN-2740.20150420-1.patch, 
> YARN-2740.20150421-1.patch
> According to YARN-2495, when distributed node label configuration is enabled:
> - RMAdmin / REST API should reject change labels on node operations.
> - CommonNodeLabelsManager shouldn't persist labels on nodes when NM do 
> heartbeat.

This message was sent by Atlassian JIRA

Reply via email to