[ https://issues.apache.org/jira/browse/YARN-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507641#comment-14507641 ]
Hadoop QA commented on YARN-3522: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 36s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 2 new or modified test files. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | javac | 7m 31s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 38s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 7m 46s | The applied patch generated 2 additional checkstyle issues. | | {color:green}+1{color} | install | 1m 32s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 58s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:red}-1{color} | yarn tests | 6m 43s | Tests failed in hadoop-yarn-applications-distributedshell. | | {color:green}+1{color} | yarn tests | 1m 56s | Tests passed in hadoop-yarn-common. | | | | 52m 37s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.yarn.applications.distributedshell.TestDistributedShell | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12727290/YARN-3522.2.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 1f4767c | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/7451/artifact/patchprocess/checkstyle-result-diff.txt | | hadoop-yarn-applications-distributedshell test log | https://builds.apache.org/job/PreCommit-YARN-Build/7451/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt | | hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/7451/artifact/patchprocess/testrun_hadoop-yarn-common.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7451/testReport/ | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7451//console | This message was automatically generated. > DistributedShell uses the wrong user to put timeline data > --------------------------------------------------------- > > Key: YARN-3522 > URL: https://issues.apache.org/jira/browse/YARN-3522 > Project: Hadoop YARN > Issue Type: Bug > Components: timelineserver > Reporter: Zhijie Shen > Assignee: Zhijie Shen > Priority: Blocker > Attachments: YARN-3522.1.patch, YARN-3522.2.patch > > > YARN-3287 breaks the timeline access control of distributed shell. In > distributed shell AM: > {code} > if (conf.getBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED, > YarnConfiguration.DEFAULT_TIMELINE_SERVICE_ENABLED)) { > // Creating the Timeline Client > timelineClient = TimelineClient.createTimelineClient(); > timelineClient.init(conf); > timelineClient.start(); > } else { > timelineClient = null; > LOG.warn("Timeline service is not enabled"); > } > {code} > {code} > ugi.doAs(new PrivilegedExceptionAction<TimelinePutResponse>() { > @Override > public TimelinePutResponse run() throws Exception { > return timelineClient.putEntities(entity); > } > }); > {code} > YARN-3287 changes the timeline client to get the right ugi at serviceInit, > but DS AM still doesn't use submitter ugi to init timeline client, but use > the ugi for each put entity call. It result in the wrong user of the put > request. -- This message was sent by Atlassian JIRA (v6.3.4#6332)