[ 
https://issues.apache.org/jira/browse/YARN-3471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509138#comment-14509138
 ] 

Steve Loughran commented on YARN-3471:
--------------------------------------

Looking at this patch, it doesn't address the issues I've encountered in 
YARN-3477

# when the retries time out, the exception causing the attempts to fail is not 
rethrown
# interrupts are being swallowed, making it impossible to reliably interrupt 
the thread

I'd like to get the YARN-3477 patches in as well as these ones, so lets see if 
we can do them in turn.

> Fix timeline client retry
> -------------------------
>
>                 Key: YARN-3471
>                 URL: https://issues.apache.org/jira/browse/YARN-3471
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: 2.8.0
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-3471.1.patch, YARN-3471.2.patch
>
>
> I found that the client retry has some problems:
> 1. The new put methods will retry on all exception, but they should only do 
> it upon ConnectException.
> 2. We can reuse TimelineClientConnectionRetry to simplify the retry logic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to