Steve Loughran updated YARN-3477:
    Attachment: YARN-3477-001.patch

Patch -001

# rethrows last received exception on a retry count failure
# caught InterruptedExceptions are converted to InterruptedIOException. This 
allows recipients to selectively look for that exception.
# no longer swallows InterruptedExceptions during sleep

There's no tests here, because there's no easy way to implement the failure 
paths.  Close review is encouraged.

There's one more thing we may want to do when handling the interrupts: 
re-enable the thread's interrupted flag. See 
[http://www.ibm.com/developerworks/library/j-jtp05236/] for the specifics here. 
I don't see any harm in doing this, and as it helps preserve the interrupted 
state, can only be a good thing

> TimelineClientImpl swallows exceptions
> --------------------------------------
>                 Key: YARN-3477
>                 URL: https://issues.apache.org/jira/browse/YARN-3477
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: timelineserver
>    Affects Versions: 2.6.0, 2.7.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: YARN-3477-001.patch
> If timeline client fails more than the retry count, the original exception is 
> not thrown. Instead some runtime exception is raised saying "retries run out"
> # the failing exception should be rethrown, ideally via 
> NetUtils.wrapException to include URL of the failing endpoing
> # Otherwise, the raised RTE should (a) state that URL and (b) set the 
> original fault as the inner cause

This message was sent by Atlassian JIRA

Reply via email to