[
https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511470#comment-14511470
]
Sangjin Lee commented on YARN-3411:
-----------------------------------
Sorry [~vrushalic] for my late comments. I took a quick pass on the POC patch,
and as with the Phoenix one I haven't fully delved into the schema-related
code, but here are some initial quick comments.
- I'm sure you're aware, but please don't forget to add the license to the new
files later.
(pom.xml)
- l.77: So do we need to depend on hbase-server? That's bit unexpected?
- Come to think of it, this is bit interesting. By timelineservice depending on
HBase, we now have a circular dependency between hadoop and HBase. Evidently it
builds (which is bit surprising), but it creates an interesting situation. I'm
wondering how we should handle this. I suppose the same issue exists with
Phoenix.
(EntityTableDetails.java)
- l.7: I think we're now moving away from the acronym "ats". Perhaps we should
simply use "timeline.entity"?
(HBaseTimelineWriterImpl.java)
- l.40: Just curious, does this mean a single writer instance has only on HBase
client connection? We should be able to have multiple connections? What is your
thought on this?
- Also, the initialization operations inside the constructor should probably
belong in serviceInit() or serviceStart()?
> [Storage implementation] explore the native HBase write schema for storage
> --------------------------------------------------------------------------
>
> Key: YARN-3411
> URL: https://issues.apache.org/jira/browse/YARN-3411
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Sangjin Lee
> Assignee: Vrushali C
> Priority: Critical
> Attachments: ATSv2BackendHBaseSchemaproposal.pdf,
> YARN-3411.poc.2.txt, YARN-3411.poc.txt
>
>
> There is work that's in progress to implement the storage based on a Phoenix
> schema (YARN-3134).
> In parallel, we would like to explore an implementation based on a native
> HBase schema for the write path. Such a schema does not exclude using
> Phoenix, especially for reads and offline queries.
> Once we have basic implementations of both options, we could evaluate them in
> terms of performance, scalability, usability, etc. and make a call.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
