[ 
https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516073#comment-14516073
 ] 

Li Lu commented on YARN-3551:
-----------------------------

Hi [~zjshen], thanks for the patch! Some quick comments and thoughts:

# Since singleData is a Number now, what is the consideration to return it as 
an Object in getSingleData?
# Since a metric object can only store one type of data (timeseries or single 
data), maybe it's helpful to have a method to distinguish these two cases?
# {{checkIfTheOhterExists}} appears to be a typo. 
# We're removing startTime and endTime here, which are used as primary keys for 
Phoenix based storage. After this JIRA we need to find an alternative way to 
store metrics in Phoenix. I'm marking this JIRA as blocking YARN-3134. 

> Consolidate data model change according to the backend implementation
> ---------------------------------------------------------------------
>
>                 Key: YARN-3551
>                 URL: https://issues.apache.org/jira/browse/YARN-3551
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-3551.1.patch
>
>
> Based on the comments on 
> [YARN-3134|https://issues.apache.org/jira/browse/YARN-3134?focusedCommentId=14512080&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512080]
>  and 
> [YARN-3411|https://issues.apache.org/jira/browse/YARN-3411?focusedCommentId=14512098&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512098],
>  we need to change the data model to restrict the data type of 
> info/config/metric section.
> 1. Info: the value could be all kinds object that is able to be 
> serialized/deserialized by jackson.
> 2. Config: the value will always be assumed as String.
> 3. Metric: single data or time series value have to be number for aggregation.
> Other than that, info/start time/finish time of metric seem not to be 
> necessary for storage. They should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to