Zhijie Shen commented on YARN-3551:

Li, thanks for the comments. See the following response.

bq. Since singleData is a Number now, what is the consideration to return it as 
an Object in getSingleData?

It's a bug, and fixed in the new patch.

bq. Since a metric object can only store one type of data (timeseries or single 
data), maybe it's helpful to have a method to distinguish these two cases?

There still exists the case that both single data and timeseries are left 
empty. So can we just go ahead to check if the data exist or not?

bq. checkIfTheOhterExists appears to be a typo.


bq. We're removing startTime and endTime here, which are used as primary keys 
for Phoenix based storage. After this JIRA we need to find an alternative way 
to store metrics in Phoenix. I'm marking this JIRA as blocking YARN-3134.

Starttime and endtime is used to define a period to query the aggregated 
information during it (see comments in [Comment 1 in 
 and [Comment 2 in 
 Hence I don't think they should be used as part of the primary key. I propose 
to remove it because I think starttime and endtime should be given as the 
request's params. The response could just be the metric object containing the 
statistic information during this given period.

> Consolidate data model change according to the backend implementation
> ---------------------------------------------------------------------
>                 Key: YARN-3551
>                 URL: https://issues.apache.org/jira/browse/YARN-3551
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-3551.1.patch, YARN-3551.2.patch
> Based on the comments on 
> [YARN-3134|https://issues.apache.org/jira/browse/YARN-3134?focusedCommentId=14512080&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512080]
>  and 
> [YARN-3411|https://issues.apache.org/jira/browse/YARN-3411?focusedCommentId=14512098&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512098],
>  we need to change the data model to restrict the data type of 
> info/config/metric section.
> 1. Info: the value could be all kinds object that is able to be 
> serialized/deserialized by jackson.
> 2. Config: the value will always be assumed as String.
> 3. Metric: single data or time series value have to be number for aggregation.
> Other than that, info/start time/finish time of metric seem not to be 
> necessary for storage. They should be removed.

This message was sent by Atlassian JIRA

Reply via email to