[ 
https://issues.apache.org/jira/browse/YARN-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518551#comment-14518551
 ] 

Vinod Kumar Vavilapalli commented on YARN-2619:
-----------------------------------------------

A very clean patch!

This is essentially a rewrite. FYI [~ywskycn].

Seems like we are also not yet tying this for scheduling, that's my expectation 
too. But add a note on this JIRA as to how sharing happens? And the defaults 
(what does a weight of 500 mean?).

Should we deprecate LCEResourcesHandler hierarchy so that future work doesn't 
go there?

CGroupsDiskResourceHandlerImpl
 - Add Override annotations for methods that are overridden so it is clear what 
behavior is dictated by the base interface
 - Print a warning if PARTITIONS_FILE cannot be read?

> NodeManager: Add cgroups support for disk I/O isolation
> -------------------------------------------------------
>
>                 Key: YARN-2619
>                 URL: https://issues.apache.org/jira/browse/YARN-2619
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wei Yan
>            Assignee: Wei Yan
>         Attachments: YARN-2619-1.patch, YARN-2619.002.patch, 
> YARN-2619.003.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to