Varun Vasudev updated YARN-2619:
    Attachment: YARN-2619.004.patch

bq. there is an unused import 
in TestCGroupsHandlerImpl 


bq. And the defaults (what does a weight of 500 mean?)

Added a comment in the implementation that it's just arbitrary.

bq. Should we deprecate LCEResourcesHandler hierarchy so that future work 
doesn't go there?

We should do it once YARN-3542 gets committed.

bq. Add Override annotations for methods that are overridden so it is clear 
what behavior is dictated by the base interface


bq. Print a warning if PARTITIONS_FILE cannot be read?


I've also re-factored part of CGroupsHandlerImpl to make testing 
cleaner(removing the need to read the controllerPaths map).

[~sidharta-s] - can you please review to make sure the refactoring is ok?

> NodeManager: Add cgroups support for disk I/O isolation
> -------------------------------------------------------
>                 Key: YARN-2619
>                 URL: https://issues.apache.org/jira/browse/YARN-2619
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wei Yan
>            Assignee: Wei Yan
>         Attachments: YARN-2619-1.patch, YARN-2619.002.patch, 
> YARN-2619.003.patch, YARN-2619.004.patch

This message was sent by Atlassian JIRA

Reply via email to