[ 
https://issues.apache.org/jira/browse/YARN-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519367#comment-14519367
 ] 

Hadoop QA commented on YARN-3445:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 34s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 2 new or modified test files. |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 15  line(s) that 
end in whitespace. |
| {color:green}+1{color} | javac |   7m 31s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 40s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   5m 20s | The applied patch generated  4 
 additional checkstyle issues. |
| {color:green}+1{color} | install |   1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with 
eclipse:eclipse. |
| {color:red}-1{color} | findbugs |   1m 59s | The patch appears to introduce 
14 new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | tools/hadoop tests |   0m 52s | Tests passed in 
hadoop-sls. |
| {color:green}+1{color} | yarn tests |  52m 26s | Tests passed in 
hadoop-yarn-server-resourcemanager. |
| | |  95m  0s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-sls |
|  |  Found reliance on default encoding in 
org.apache.hadoop.yarn.sls.RumenToSLSConverter.generateSLSLoadFile(String, 
String):in 
org.apache.hadoop.yarn.sls.RumenToSLSConverter.generateSLSLoadFile(String, 
String): new java.io.FileReader(String)  At RumenToSLSConverter.java:[line 122] 
|
|  |  Found reliance on default encoding in 
org.apache.hadoop.yarn.sls.RumenToSLSConverter.generateSLSLoadFile(String, 
String):in 
org.apache.hadoop.yarn.sls.RumenToSLSConverter.generateSLSLoadFile(String, 
String): new java.io.FileWriter(String)  At RumenToSLSConverter.java:[line 124] 
|
|  |  Found reliance on default encoding in 
org.apache.hadoop.yarn.sls.RumenToSLSConverter.generateSLSNodeFile(String):in 
org.apache.hadoop.yarn.sls.RumenToSLSConverter.generateSLSNodeFile(String): new 
java.io.FileWriter(String)  At RumenToSLSConverter.java:[line 145] |
|  |  Found reliance on default encoding in 
org.apache.hadoop.yarn.sls.SLSRunner.startAMFromSLSTraces(Resource, int):in 
org.apache.hadoop.yarn.sls.SLSRunner.startAMFromSLSTraces(Resource, int): new 
java.io.FileReader(String)  At SLSRunner.java:[line 280] |
|  |  Unwritten field:NodeInfo.java:[line 140] |
|  |  Found reliance on default encoding in 
org.apache.hadoop.yarn.sls.scheduler.ResourceSchedulerWrapper.initMetrics():in 
org.apache.hadoop.yarn.sls.scheduler.ResourceSchedulerWrapper.initMetrics(): 
new java.io.FileWriter(String)  At ResourceSchedulerWrapper.java:[line 490] |
|  |  Found reliance on default encoding in new 
org.apache.hadoop.yarn.sls.scheduler.ResourceSchedulerWrapper$MetricsLogRunnable(ResourceSchedulerWrapper):in
 new 
org.apache.hadoop.yarn.sls.scheduler.ResourceSchedulerWrapper$MetricsLogRunnable(ResourceSchedulerWrapper):
 new java.io.FileWriter(String)  At ResourceSchedulerWrapper.java:[line 695] |
|  |  Found reliance on default encoding in 
org.apache.hadoop.yarn.sls.scheduler.SLSCapacityScheduler.initMetrics():in 
org.apache.hadoop.yarn.sls.scheduler.SLSCapacityScheduler.initMetrics(): new 
java.io.FileWriter(String)  At SLSCapacityScheduler.java:[line 493] |
|  |  Found reliance on default encoding in new 
org.apache.hadoop.yarn.sls.scheduler.SLSCapacityScheduler$MetricsLogRunnable(SLSCapacityScheduler):in
 new 
org.apache.hadoop.yarn.sls.scheduler.SLSCapacityScheduler$MetricsLogRunnable(SLSCapacityScheduler):
 new java.io.FileWriter(String)  At SLSCapacityScheduler.java:[line 698] |
|  |  Found reliance on default encoding in 
org.apache.hadoop.yarn.sls.utils.SLSUtils.parseNodesFromNodeFile(String):in 
org.apache.hadoop.yarn.sls.utils.SLSUtils.parseNodesFromNodeFile(String): new 
java.io.FileReader(String)  At SLSUtils.java:[line 119] |
|  |  Found reliance on default encoding in 
org.apache.hadoop.yarn.sls.utils.SLSUtils.parseNodesFromSLSTrace(String):in 
org.apache.hadoop.yarn.sls.utils.SLSUtils.parseNodesFromSLSTrace(String): new 
java.io.FileReader(String)  At SLSUtils.java:[line 92] |
|  |  Class org.apache.hadoop.yarn.sls.web.SLSWebApp defines non-transient 
non-serializable instance field handleOperTimecostHistogramMap  In 
SLSWebApp.java:instance field handleOperTimecostHistogramMap  In SLSWebApp.java 
|
|  |  Class org.apache.hadoop.yarn.sls.web.SLSWebApp defines non-transient 
non-serializable instance field queueAllocatedMemoryCounterMap  In 
SLSWebApp.java:instance field queueAllocatedMemoryCounterMap  In SLSWebApp.java 
|
|  |  Class org.apache.hadoop.yarn.sls.web.SLSWebApp defines non-transient 
non-serializable instance field queueAllocatedVCoresCounterMap  In 
SLSWebApp.java:instance field queueAllocatedVCoresCounterMap  In SLSWebApp.java 
|
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12728844/YARN-3445-v2.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 8f82970 |
| whitespace | 
https://builds.apache.org/job/PreCommit-YARN-Build/7539/artifact/patchprocess/whitespace.txt
 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-YARN-Build/7539/artifact/patchprocess/checkstyle-result-diff.txt
 |
| Findbugs warnings | 
https://builds.apache.org/job/PreCommit-YARN-Build/7539/artifact/patchprocess/newPatchFindbugsWarningshadoop-sls.html
 |
| hadoop-sls test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/7539/artifact/patchprocess/testrun_hadoop-sls.txt
 |
| hadoop-yarn-server-resourcemanager test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/7539/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/7539/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/7539/console |


This message was automatically generated.

> Cache runningApps in RMNode for getting running apps on given NodeId
> --------------------------------------------------------------------
>
>                 Key: YARN-3445
>                 URL: https://issues.apache.org/jira/browse/YARN-3445
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>    Affects Versions: 2.7.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: YARN-3445-v2.patch, YARN-3445.patch
>
>
> Per discussion in YARN-3334, we need filter out unnecessary collectors info 
> from RM in heartbeat response. Our propose is to add cache for runningApps in 
> RMNode, so RM only send collectors for local running apps back. This is also 
> needed in YARN-914 (graceful decommission) that if no running apps in NM 
> which is in decommissioning stage, it will get decommissioned immediately. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to