[
https://issues.apache.org/jira/browse/YARN-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520838#comment-14520838
]
sandflee commented on YARN-3546:
--------------------------------
The implement of AbstractYarnScheduler.getApplicationAttempt has no problem,
just the name and parrameters confusing me when I view launchAM failures in
YARN-3387 and maybe confusing other scheduler newbies.
I wondered If I had explained more clearly, sorry for that.
> AbstractYarnScheduler.getApplicationAttempt seems misleading, and there're
> some misuse of it
> ---------------------------------------------------------------------------------------------
>
> Key: YARN-3546
> URL: https://issues.apache.org/jira/browse/YARN-3546
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Reporter: sandflee
>
> I'm not familiar with scheduler, with first eyes, I thought this func
> returns the schdulerAppAttempt info corresponding to appAttemptId, but
> actually it returns the current schdulerAppAttempt.
> It seems misled others too, such as
> TestWorkPreservingRMRestart.waitForNumContainersToRecover
> MockRM.waitForSchedulerAppAttemptAdded
> should I rename it to T getCurrentSchedulerApplicationAttempt(ApplicationId
> applicationid)
> or returns null if current attempt id not equals to the request attempt id ?
> comment preferred!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
