Junping Du commented on YARN-3445:

Thanks for comments, [~vinodkv]!

bq. logAggregationReportsForApps itself is a map of ApplicationID with a nested 
LogAggregationReport.ApplicationID - duplicate AppID information
Are u suggest we should replace map with list in NodeHeartbeatRequest? I fully 
agree and I will suggest to do so in YARN-3505.

bq. runningApplications in this patch
In v2 patch, runningApplications is already removed. Kindly check the v2 patch 

bq. NodeStatus.keepAliveApplications
I agree. This shouldn't be needed anymore after YARN-1402. I had the similar 
idea before in synced with Xuan but forget to put it on JIRA. May be we should 
file a separated JIRA to fix it?

CC [~xgong].

> Cache runningApps in RMNode for getting running apps on given NodeId
> --------------------------------------------------------------------
>                 Key: YARN-3445
>                 URL: https://issues.apache.org/jira/browse/YARN-3445
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>    Affects Versions: 2.7.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: YARN-3445-v2.patch, YARN-3445.patch
> Per discussion in YARN-3334, we need filter out unnecessary collectors info 
> from RM in heartbeat response. Our propose is to add cache for runningApps in 
> RMNode, so RM only send collectors for local running apps back. This is also 
> needed in YARN-914 (graceful decommission) that if no running apps in NM 
> which is in decommissioning stage, it will get decommissioned immediately. 

This message was sent by Atlassian JIRA

Reply via email to