[
https://issues.apache.org/jira/browse/YARN-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521628#comment-14521628
]
Junping Du commented on YARN-3505:
----------------------------------
Sorry for comments a little late. Some initiative comments/questions after go
though the patch quickly:
- Why we need LogAggregationReportInNM which is the same as
LogAggregationReport? Is this just duplicated with LogAggregationReport?
- Why we need to differentiate diagnosticMessage with failureMessages in
LogAggregationReport? If we don't want to cache successful report, we can
differentiate from LogAggregationStatus. Isn't it?
- From Vinod's comments in YARN-3445
(https://issues.apache.org/jira/browse/YARN-3445?focusedCommentId=14520396&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14520396),
we have duplicated applicationID info for logAggregationReportsForApps, so I
think we replace map (appID -> logAggregationReport) with list of
logAggregationReport (or a SET with override equalsTo with comparing
applicationID only).
> Node's Log Aggregation Report with SUCCEED should not cached in RMApps
> ----------------------------------------------------------------------
>
> Key: YARN-3505
> URL: https://issues.apache.org/jira/browse/YARN-3505
> Project: Hadoop YARN
> Issue Type: Bug
> Components: log-aggregation
> Affects Versions: 2.8.0
> Reporter: Junping Du
> Assignee: Xuan Gong
> Priority: Critical
> Attachments: YARN-3505.1.patch
>
>
> Per discussions in YARN-1402, we shouldn't cache all node's log aggregation
> reports in RMApps for always, especially for those finished with SUCCEED.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
