[ 
https://issues.apache.org/jira/browse/YARN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522180#comment-14522180
 ] 

Wangda Tan commented on YARN-3521:
----------------------------------

[~sunilg], Thanks for updating, just tried it locally, some comments:
1) it seems the structure of REST response is not correct for NodeLabelsInfo:
{code}
<nodeLabelsInfo>
<nodeLabelsInfo>
<name>x</name>
<exclusity>true</exclusity>
</nodeLabelsInfo>
<nodeLabelsInfo>
<name>y</name>
<exclusity>true</exclusity>
</nodeLabelsInfo>
</nodeLabelsInfo>
{code}

It should be {{nodeLabelInfo}} instead of {{nodeLabelsInfo}}, could you solve 
this issue?

2) It's better to add a test for specifying exclusivity when adding node 
labels. (Verify exclusivity added to NodeLabelsManager).



> Support return structured NodeLabel objects in REST API when call 
> getClusterNodeLabels
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-3521
>                 URL: https://issues.apache.org/jira/browse/YARN-3521
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>         Attachments: 0001-YARN-3521.patch, 0002-YARN-3521.patch
>
>
> In YARN-3413, yarn cluster CLI returns NodeLabel instead of String, we should 
> make the same change in REST API side to make them consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to