Zhijie Shen commented on YARN-1462:

Xuan, thanks for the patch. It's good overall. Some comments bellow:

1. ApplicationReport.newInstance seems not to be stable, and it's private. 
Shall we change it directly?

2. Can we define the constant by using the same name pattern that we used 
public static final String APP_TAGS = "YARN_APPLICATION_TAGS";

3. Is it possible that {{obj}} is null?
280             Object obj = 
281             if (obj instanceof Collection<?>) {

4. Can we add a test in TestApplicationHistoryManagerOnTimelineStore too?

> AHS API and other AHS changes to handle tags for completed MR jobs
> ------------------------------------------------------------------
>                 Key: YARN-1462
>                 URL: https://issues.apache.org/jira/browse/YARN-1462
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.2.0
>            Reporter: Karthik Kambatla
>            Assignee: Xuan Gong
>         Attachments: YARN-1462.1.patch
> AHS related work for tags. 

This message was sent by Atlassian JIRA

Reply via email to