Junping Du commented on YARN-2401:

Just sync with Zhijie offline that we have new version of TimelineService and 
we should keep compatible of API for old service. Will close it as won't fix.

> Rethinking of the HTTP method of TimelineWebServices#postEntities
> -----------------------------------------------------------------
>                 Key: YARN-2401
>                 URL: https://issues.apache.org/jira/browse/YARN-2401
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
> Now TimelineWebServices#postEntities is using POST. However, semantically, 
> postEntities is creating an entity or append more data into it. POST may not 
> be the most proper method to for this API.
> AFAIK, PUT is used to update the entire resource and supposed to be 
> idempotent. Therefore, I'm not sure it's an idea to change the method to PUT 
> because once the entity is created, the following updates are actually 
> appending more data to the existing one. The best fit should be PATCH, 
> however, it requires the additional implementation at the web services side. 
> Hence, somebody online suggested using POST for partial non-idempotent update 
> as well. We need to think more about it.

This message was sent by Atlassian JIRA

Reply via email to