[ 
https://issues.apache.org/jira/browse/YARN-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524190#comment-14524190
 ] 

Xuan Gong commented on YARN-1971:
---------------------------------

[~rusanu] 
bq. These can fail due to access permissions, disc out of space, bad hardware, 
cosmic rays etc etc. There should be proper error checking to ease 
troubleshooting.

I agree. The script can fail due to those issues. But for example "disc out of 
space, bad hardware," belongs to NM issue. We have already handle them at NM 
side. So, do we really need some pre-check for those issues ? It might not be 
easy.

> WindowsLocalWrapperScriptBuilder does not check for errors in generated script
> ------------------------------------------------------------------------------
>
>                 Key: YARN-1971
>                 URL: https://issues.apache.org/jira/browse/YARN-1971
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Remus Rusanu
>            Assignee: Remus Rusanu
>            Priority: Minor
>
> Similar to YARN-1865. The 
> DefaultContainerExecutor.WindowsLocalWrapperScriptBuilder builds a shell 
> script that contains commands that potentially may fail:
> {code}
> pout.println("@echo " + containerIdStr + " > " + normalizedPidFile +".tmp");
> pout.println("@move /Y " + normalizedPidFile + ".tmp " + normalizedPidFile); 
> {code}
> These can fail due to access permissions, disc out of space, bad hardware, 
> cosmic rays etc etc. There should be proper error checking to ease 
> troubleshooting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to