[ 
https://issues.apache.org/jira/browse/YARN-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524295#comment-14524295
 ] 

Li Lu commented on YARN-3477:
-----------------------------

Hi [~ste...@apache.org], thanks for the patch! The fixes on the timeline retry 
logic looks good to me. BTW, I agree with [~zjshen] that we may want to change 
some retry information's log level into debug. I used info level, but then 
found this may generate some noise in a log with retries. 

> TimelineClientImpl swallows exceptions
> --------------------------------------
>
>                 Key: YARN-3477
>                 URL: https://issues.apache.org/jira/browse/YARN-3477
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: timelineserver
>    Affects Versions: 2.6.0, 2.7.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: YARN-3477-001.patch, YARN-3477-002.patch
>
>
> If timeline client fails more than the retry count, the original exception is 
> not thrown. Instead some runtime exception is raised saying "retries run out"
> # the failing exception should be rethrown, ideally via 
> NetUtils.wrapException to include URL of the failing endpoing
> # Otherwise, the raised RTE should (a) state that URL and (b) set the 
> original fault as the inner cause



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to