[ 
https://issues.apache.org/jira/browse/YARN-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524730#comment-14524730
 ] 

Hadoop QA commented on YARN-1329:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch |   0m  0s | The patch command could not apply 
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12613087/YARN-1329.patch |
| Optional Tests | shellcheck |
| git revision | trunk / f1a152c |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/7595/console |


This message was automatically generated.

> yarn-config.sh overwrites YARN_CONF_DIR indiscriminately 
> ---------------------------------------------------------
>
>                 Key: YARN-1329
>                 URL: https://issues.apache.org/jira/browse/YARN-1329
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager, resourcemanager
>            Reporter: Aaron Gottlieb
>            Assignee: haosdent
>              Labels: easyfix
>         Attachments: YARN-1329.patch
>
>
> The script yarn-daemons.sh calls 
> {code}${HADOOP_LIBEXEC_DIR}/yarn-config.sh{code}
> yarn-config.sh overwrites any previously set value of environment variable 
> YARN_CONF_DIR starting at line 40:
> {code:title=yarn-config.sh|borderStyle=solid}
> #check to see if the conf dir is given as an optional argument
> if [ $# -gt 1 ]
> then
>     if [ "--config" = "$1" ]
>         then
>             shift
>             confdir=$1
>             shift
>             YARN_CONF_DIR=$confdir
>     fi
> fi
>  
> # Allow alternate conf dir location.
> export YARN_CONF_DIR="${HADOOP_CONF_DIR:-$HADOOP_YARN_HOME/conf}"
> {code}
> The last line should check for the existence of YARN_CONF_DIR first.
> {code}
> DEFAULT_CONF_DIR="${HADOOP_CONF_DIR:-$YARN_HOME/conf}"
> export YARN_CONF_DIR="${YARN_CONF_DIR:-$DEFAULT_CONF_DIR}"
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to