[ 
https://issues.apache.org/jira/browse/YARN-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524984#comment-14524984
 ] 

Hadoop QA commented on YARN-2756:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch |   0m  0s | The patch command could not apply 
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12677441/YARN-2756.000.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f1a152c |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/7636/console |


This message was automatically generated.

> use static variable (Resources.none()) for not-running Node.resource in 
> CommonNodeLabelsManager to save memory.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2756
>                 URL: https://issues.apache.org/jira/browse/YARN-2756
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>         Attachments: YARN-2756.000.patch
>
>
> use static variable (Resources.none()) for not-running Node.resource in 
> CommonNodeLabelsManager to save memory. When a Node is not activated, the 
> resource is never used, When a Node is activated, a new resource will be 
> assigned to it in RMNodeLabelsManager#activateNode (nm.resource = resource) 
> So it would be better to use static variable Resources.none() instead of 
> allocating a new variable(Resource.newInstance(0, 0)) for each node 
> deactivation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to