[ 
https://issues.apache.org/jira/browse/YARN-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525006#comment-14525006
 ] 

Hadoop QA commented on YARN-2757:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch |   0m  0s | The patch command could not apply 
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12677472/YARN-2757.000.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f1a152c |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/7643/console |


This message was automatically generated.

> potential NPE in checkNodeLabelExpression of SchedulerUtils for nodeLabels.
> ---------------------------------------------------------------------------
>
>                 Key: YARN-2757
>                 URL: https://issues.apache.org/jira/browse/YARN-2757
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>         Attachments: YARN-2757.000.patch
>
>
> pontential NPE in checkNodeLabelExpression of SchedulerUtils for nodeLabels.
> since we check the nodeLabels null at 
> {code}
>         if (!str.trim().isEmpty()
>             && (nodeLabels == null || !nodeLabels.contains(str.trim()))) {
>           return false;
>         }
> {code}
> We should also check nodeLabels null at 
> {code}
>       if (!nodeLabels.isEmpty()) {
>         return false;
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to