Remus Rusanu commented on YARN-1971:

The problem is that there is no error check in the generated script. For 
comparison the ContainerLaunch.WindowsShellScriptBuilder will check each line 
in the generated script by adding this line automatically in the script, after 
each command:
@if %errorlevel% neq 0 exit /b %errorlevel%

I'm not advocating checking for various error conditions before launching the 
script, I'm saying the generated script itself should have error checking and 

> WindowsLocalWrapperScriptBuilder does not check for errors in generated script
> ------------------------------------------------------------------------------
>                 Key: YARN-1971
>                 URL: https://issues.apache.org/jira/browse/YARN-1971
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Remus Rusanu
>            Assignee: Remus Rusanu
>            Priority: Minor
> Similar to YARN-1865. The 
> DefaultContainerExecutor.WindowsLocalWrapperScriptBuilder builds a shell 
> script that contains commands that potentially may fail:
> {code}
> pout.println("@echo " + containerIdStr + " > " + normalizedPidFile +".tmp");
> pout.println("@move /Y " + normalizedPidFile + ".tmp " + normalizedPidFile); 
> {code}
> These can fail due to access permissions, disc out of space, bad hardware, 
> cosmic rays etc etc. There should be proper error checking to ease 
> troubleshooting.

This message was sent by Atlassian JIRA

Reply via email to