Eric Payne commented on YARN-3097:

-1      The patch doesn't appear to include any new or modified tests. Please 
justify why no new tests are needed for this patch. Also please list what 
manual steps were performed to verify this patch.

Since the only change in this patch is to change an info log message to a debug 
log message, no tests were included.

> Logging of resource recovery on NM restart has redundancies
> -----------------------------------------------------------
>                 Key: YARN-3097
>                 URL: https://issues.apache.org/jira/browse/YARN-3097
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.5.0
>            Reporter: Jason Lowe
>            Assignee: Eric Payne
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-3097.001.patch
> ResourceLocalizationService logs that it is recovering a resource with the 
> remote and local paths, but then very shortly afterwards the 
> LocalizedResource emits an INIT->LOCALIZED transition that also logs the same 
> remote and local paths.  The recovery message should be a debug message, 
> since it's not conveying any useful information that isn't already covered by 
> the resource state transition log.

This message was sent by Atlassian JIRA

Reply via email to