[
https://issues.apache.org/jira/browse/YARN-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528247#comment-14528247
]
Junping Du commented on YARN-3396:
----------------------------------
Thanks [~brahmareddy] for delivering a patch here. Several quick feedback here:
1. Why we are setting log level to INFO in the first case while setting ERROR
for the second case? I think we should keep consistent here, probably ERROR is
suitable for both cases.
2. This particular exception get thrown when decoding path from URL it
contains, so we should put rsrc.getResource() and next.getResource() there
instead of others you are putting now.
3. More informative words than just "Got exception parsing." - may be something
like "Got exception in parsing URL of LocalResource: " + next.getResource()?
> Handle URISyntaxException in ResourceLocalizationService
> --------------------------------------------------------
>
> Key: YARN-3396
> URL: https://issues.apache.org/jira/browse/YARN-3396
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.7.0
> Reporter: Chengbing Liu
> Assignee: Brahma Reddy Battula
> Attachments: YARN-3396.patch
>
>
> There are two occurrences of the following code snippet:
> {code}
> //TODO fail? Already translated several times...
> {code}
> It should be handled correctly in case that the resource URI is incorrect.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
