[ 
https://issues.apache.org/jira/browse/YARN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531212#comment-14531212
 ] 

Wangda Tan commented on YARN-3521:
----------------------------------

Some more comments:
- NodeLabelsName is not necessary for 
removeFromCluserNodeLabels/replaceLabelsOnNode, use ArrayList seems enough and 
clean to me
- replaceLabelsOnNodes can take List of NodeToLabelsEntry, which contains 
String nodeId and ArrayList<String> labels, this will be simpler than 
maintaining two objects: NodeToLabelsName and NodeLabelsName to me.

Sounds good? [~sunilg]/[~vinodkv]?

> Support return structured NodeLabel objects in REST API when call 
> getClusterNodeLabels
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-3521
>                 URL: https://issues.apache.org/jira/browse/YARN-3521
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>         Attachments: 0001-YARN-3521.patch, 0002-YARN-3521.patch, 
> 0003-YARN-3521.patch, 0004-YARN-3521.patch, 0005-YARN-3521.patch
>
>
> In YARN-3413, yarn cluster CLI returns NodeLabel instead of String, we should 
> make the same change in REST API side to make them consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to