[ 
https://issues.apache.org/jira/browse/YARN-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531323#comment-14531323
 ] 

Akira AJISAKA commented on YARN-3069:
-------------------------------------

Thanks [~rchiang] for updating the patch. Reviewed parameters from 
{{yarn.resourcemanager.delegation-token-renewer.thread-count}} to 
{{mapreduce.job.hdfs-servers}}.

bq. yarn.resourcemanager.delegation.token.max-lifetime
Would you add the time unit (ms) in the description?

bq. yarn.resourcemanager.nm-tokens.master-key-rolling-interval-secs
Default value is 86400 (24*60*60) sec.

bq. yarn.resourcemanager.reservation-system.class
By default, 
{{org.apache.hadoop.yarn.server.resourcemanager.reservation.CapacityReservationSystem}}
 is used when using CapacityScheduler, and 
{{org.apache.hadoop.yarn.server.resourcemanager.reservation.FairReservationSystem}}
 is used when using FairScheduler.

bq. yarn.resourcemanager.reservation-system.plan.follower
By default, 
{{org.apache.hadoop.yarn.server.resourcemanager.reservation.CapacitySchedulerPlanFollower}}
 is used when using CapacityScheduler, and 
{{org.apache.hadoop.yarn.server.resourcemanager.reservation.FairSchedulerPlanFollower}}
 is used when using FairScheduler.

{code}
+   
<name>yarn.nodemanager.linux-container-executor.cgroups.delete-delay-ms</name>
+   <value>20></value>
{code}
Misformatted value tag.

bq. yarn.nodemanager.linux-container-executor.cgroups.delete-timeout-ms
Default value is 1000.

bq. yarn.nodemanager.linux-container-executor.group
I don't think the parameter should be on yarn-default.xml since the parameter 
is set by container-executor.cfg.

bq. yarn.nodemanager.user-home-dir
The home directory of the user for containers. Default value is "/home/".

{code}
-   <name>mapreduce.job.hdfs-servers</name>             
-   <value>${fs.defaultFS}</value>
{code}
I'm thinking we cannot delete the parameter since it is used by 
{{JobSubmitter#populateTokenCache}}.

> Document missing properties in yarn-default.xml
> -----------------------------------------------
>
>                 Key: YARN-3069
>                 URL: https://issues.apache.org/jira/browse/YARN-3069
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>              Labels: BB2015-05-TBR, supportability
>         Attachments: YARN-3069.001.patch, YARN-3069.002.patch, 
> YARN-3069.003.patch, YARN-3069.004.patch, YARN-3069.005.patch, 
> YARN-3069.006.patch
>
>
> The following properties are currently not defined in yarn-default.xml.  
> These properties should either be
>   A) documented in yarn-default.xml OR
>   B)  listed as an exception (with comments, e.g. for internal use) in the 
> TestYarnConfigurationFields unit test
> Any comments for any of the properties below are welcome.
>   org.apache.hadoop.yarn.server.sharedcachemanager.RemoteAppChecker
>   org.apache.hadoop.yarn.server.sharedcachemanager.store.InMemorySCMStore
>   security.applicationhistory.protocol.acl
>   yarn.app.container.log.backups
>   yarn.app.container.log.dir
>   yarn.app.container.log.filesize
>   yarn.client.app-submission.poll-interval
>   yarn.client.application-client-protocol.poll-timeout-ms
>   yarn.is.minicluster
>   yarn.log.server.url
>   yarn.minicluster.control-resource-monitoring
>   yarn.minicluster.fixed.ports
>   yarn.minicluster.use-rpc
>   yarn.node-labels.fs-store.retry-policy-spec
>   yarn.node-labels.fs-store.root-dir
>   yarn.node-labels.manager-class
>   yarn.nodemanager.container-executor.os.sched.priority.adjustment
>   yarn.nodemanager.container-monitor.process-tree.class
>   yarn.nodemanager.disk-health-checker.enable
>   yarn.nodemanager.docker-container-executor.image-name
>   yarn.nodemanager.linux-container-executor.cgroups.delete-timeout-ms
>   yarn.nodemanager.linux-container-executor.group
>   yarn.nodemanager.log.deletion-threads-count
>   yarn.nodemanager.user-home-dir
>   yarn.nodemanager.webapp.https.address
>   yarn.nodemanager.webapp.spnego-keytab-file
>   yarn.nodemanager.webapp.spnego-principal
>   yarn.nodemanager.windows-secure-container-executor.group
>   yarn.resourcemanager.configuration.file-system-based-store
>   yarn.resourcemanager.delegation-token-renewer.thread-count
>   yarn.resourcemanager.delegation.key.update-interval
>   yarn.resourcemanager.delegation.token.max-lifetime
>   yarn.resourcemanager.delegation.token.renew-interval
>   yarn.resourcemanager.history-writer.multi-threaded-dispatcher.pool-size
>   yarn.resourcemanager.metrics.runtime.buckets
>   yarn.resourcemanager.nm-tokens.master-key-rolling-interval-secs
>   yarn.resourcemanager.reservation-system.class
>   yarn.resourcemanager.reservation-system.enable
>   yarn.resourcemanager.reservation-system.plan.follower
>   yarn.resourcemanager.reservation-system.planfollower.time-step
>   yarn.resourcemanager.rm.container-allocation.expiry-interval-ms
>   yarn.resourcemanager.webapp.spnego-keytab-file
>   yarn.resourcemanager.webapp.spnego-principal
>   yarn.scheduler.include-port-in-node-name
>   yarn.timeline-service.delegation.key.update-interval
>   yarn.timeline-service.delegation.token.max-lifetime
>   yarn.timeline-service.delegation.token.renew-interval
>   yarn.timeline-service.generic-application-history.enabled
>   
> yarn.timeline-service.generic-application-history.fs-history-store.compression-type
>   yarn.timeline-service.generic-application-history.fs-history-store.uri
>   yarn.timeline-service.generic-application-history.store-class
>   yarn.timeline-service.http-cross-origin.enabled
>   yarn.tracking.url.generator



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to