[ 
https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531731#comment-14531731
 ] 

Li Lu commented on YARN-644:
----------------------------

Hi [~varun_saxena], sorry I accidentally assigned this JIRA to myself. I've 
already assigned back. I looked at you patch and in general it LGTM. I noticed 
there are some formatting issues around:
{code}
+      protected NMTokenIdentifier selectNMTokenIdentifier(
+             UserGroupInformation remoteUgi) {
{code}
since there's a mixing tab. To prove the current fix works and to prevent 
future mistakes, may be we'd like to add some test cases to verify on the null 
checks? 

> Basic null check is not performed on passed in arguments before using them in 
> ContainerManagerImpl.startContainer
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-644
>                 URL: https://issues.apache.org/jira/browse/YARN-644
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Omkar Vinit Joshi
>            Assignee: Varun Saxena
>            Priority: Minor
>              Labels: BB2015-05-TBR, newbie
>         Attachments: YARN-644.001.patch, YARN-644.002.patch
>
>
> I see that validation/ null check is not performed on passed in parameters. 
> Ex. tokenId.getContainerID().getApplicationAttemptId() inside 
> ContainerManagerImpl.authorizeRequest()
> I guess we should add these checks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to