Li Lu commented on YARN-868:

Hi [~varun_saxena], thanks for working on this! I agree with [~djp] that more 
background information would be helpful. (/cc [~hitesh]). Overall, I think the 
patch LGTM, but I would like to make sure a few things:
# Do we want to mark the newly added getServiceAddress to be public and stable 
(especially when we have a private and unstable setter)? 
# I'm not familiar with the background of this JIRA, but how is the default 
port 8080 chosen in the tests? 
# There are some unrelated formatting changes. 
# Since we're adding a new field in tokens, do you think it's worthwhile to add 
special test cases on the system working with old token formats? We may not 
want to simply exempt them in the tests but define a standard behavior for 
them. Personally, I think this is important to keep rolling upgrade feature 

I'm open in discussion in your design choices for all these points, of course. 

> YarnClient should set the service address in tokens returned by 
> getRMDelegationToken()
> --------------------------------------------------------------------------------------
>                 Key: YARN-868
>                 URL: https://issues.apache.org/jira/browse/YARN-868
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Varun Saxena
>              Labels: BB2015-05-TBR
>         Attachments: YARN-868.patch
> Either the client should set this information into the token or the client 
> layer should expose an api that returns the service address.

This message was sent by Atlassian JIRA

Reply via email to