[ 
https://issues.apache.org/jira/browse/YARN-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532250#comment-14532250
 ] 

Varun Saxena commented on YARN-868:
-----------------------------------

Thanks [~djp] and [~gtCarrera9] for reviewing this.

To give you a background, refer to linked [file in 
Tez|https://github.com/apache/tez/blob/master/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/client/ResourceMgrDelegate.java].
Here as you can see, Tez needs service address while getting Delegation token 
This address is currently taken from the config 
{{yarn.resourcemenager.address}} instead of the actual RM address which 
returned the token in case of HA.
I am not aware though about what Tez does with this service address though. 
Hitesh can probably throw some light on that.

Coming to other comments,
bq. Do we want to mark the newly added getServiceAddress to be public and 
stable (especially when we have a private and unstable setter)?
True, I will mark it as public and unstable.

bq.Since we're adding a new field in tokens, do you think it's worthwhile to 
add special test cases on the system working with old token formats? We may not 
want to simply exempt them in the tests but define a standard behavior for 
them. Personally, I think this is important to keep rolling upgrade feature 
safe.
The change in token applies only to client side. I haven't changed TokenProto 
so token transferred over wire would still remain same. I did not create a new 
class to incorporate this change to maintain API backwards compatible. Let me 
know if you feel differently.

Will fix checkstyle and whitespace issues.

> YarnClient should set the service address in tokens returned by 
> getRMDelegationToken()
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-868
>                 URL: https://issues.apache.org/jira/browse/YARN-868
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Varun Saxena
>              Labels: BB2015-05-TBR
>         Attachments: YARN-868.patch
>
>
> Either the client should set this information into the token or the client 
> layer should expose an api that returns the service address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to