Wangda Tan commented on YARN-3362:

Hi [~Naganarasimha],
Thanks a lot for updating, looks much better now! I still have few minor 

*For UI:*

1) "Configured Capacity", "Configured Max Capacity" should be a part of "Queue 
Status for Partition..."?
2) Not caused by your patch, Absolute Capacity should be "Absolute Configured 
Capacity", Absolute Max Capacity should be "Absolute Configured Max Capacity", 
could you update them in your patch?
3) Also not caused by your patch, there's no space between "Active Users Info" 
and following queue, I'm not sure if there's any easy fix can do, please feel 
free to file a separate ticket if it will be hard to be solved together.

*For implementation:*
1) One minor comment for style is, you can merge all capacities-related 
rendering in CapacitySchedulerPage to a method similar to 
renderCommonLeafQueueInfo, which you can merge some implementation for 
{{render}} and {{renderLeafQueueInfoWithoutParition}}. And add a method 
renderLeafQueueInfoWithParition to make {{render}} looks cleaner.

*For your question*
bq. May be i did not get this completely. label is exclusive-label i have done 
in CapacitySchedulerPage.QueuesBlock.render(l num - 357)
I think for both CapacitySchedulerPage and CapacitySchedulerInfo, it should be:
        if (label.getIsExclusive()
        && !((AbstractCSQueue) 
root).accessibleToPartition(label.getLabelName())) {
When label is exclusive (nobody can use the label except queue is accessible to 
the label) and (queue isn't accessible to the label), we don't need to continue.

Let me know your thoughts.

CC: [~vinodkv]/[~jianhe].

> Add node label usage in RM CapacityScheduler web UI
> ---------------------------------------------------
>                 Key: YARN-3362
>                 URL: https://issues.apache.org/jira/browse/YARN-3362
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, resourcemanager, webapp
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>         Attachments: 2015.05.06 Folded Queues.png, 2015.05.06 Queue 
> Expanded.png, 2015.05.07_3362_Queue_Hierarchy.png, CSWithLabelsView.png, 
> Screen Shot 2015-04-29 at 11.42.17 AM.png, 
> YARN-3362.20150428-3-modified.patch, YARN-3362.20150428-3.patch, 
> YARN-3362.20150506-1.patch, YARN-3362.20150507-1.patch, capacity-scheduler.xml
> We don't have node label usage in RM CapacityScheduler web UI now, without 
> this, user will be hard to understand what happened to nodes have labels 
> assign to it.

This message was sent by Atlassian JIRA

Reply via email to