Wangda Tan commented on YARN-3581:

Hi [~Naganarasimha],
Thanks for trying and thinking about this, assigning to you, please go ahead. 

#1/#3/#4 make sense to me

For #2, good point, I think we need add {{".."}} for {{label(...),label(...)}}, 
like {{"label(...),label(...)"}}. This should in usage/help message as well. 
I'm open to change "( )" to "[ ]", but I'm not sure if other shell requires 
escape "[..]" too. For now I prefer to keep "(...)", not adding new syntax, but 
document it in help message.

In addition, similar to #2, "-replaceLabelsOnNode" has problem when admin 
specified multiple "host=" in a same line without using "..". I think we should 
add using "..." in help message as well. If admin forgot to add "...", we 
should handle it instead of ignore "host=" after first one.

Let me know your thoughts.


> Deprecate -directlyAccessNodeLabelStore in RMAdminCLI
> -----------------------------------------------------
>                 Key: YARN-3581
>                 URL: https://issues.apache.org/jira/browse/YARN-3581
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
> In 2.6.0, we added an option called "-directlyAccessNodeLabelStore" to make 
> RM can start with label-configured queue settings. After YARN-2918, we don't 
> need this option any more, admin can configure queue setting, start RM and 
> configure node label via RMAdminCLI without any error.
> In addition, this option is very restrictive, first it needs to run on the 
> same node where RM is running if admin configured to store labels in local 
> disk.
> Second, when admin run the option when RM is running, multiple process write 
> to a same file can happen, this could make node label store becomes invalid.

This message was sent by Atlassian JIRA

Reply via email to