[
https://issues.apache.org/jira/browse/YARN-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534097#comment-14534097
]
Tsuyoshi Ozawa commented on YARN-3599:
--------------------------------------
[~gliptak], thank you for taking this issue. Looks good to me overall. Could
you check following points?
Please check indentation of line of "in milliseconds" - it seems to have
additional space.
{code}
* @param delegationTokenRenewInterval how often the tokens must be renewed
+ * in milliseconds
{code}
A following line is over 80 characters.
{code}
+ * @param delegationTokenRemoverScanInterval how often the tokens are
scanned
{code}
The link looks to be broken. Should we just remove link annotation?
{code}
+ * @param rmContext current context of the {@link ResourceManager}
{code}
> Fix the javadoc of DelegationTokenSecretManager in hadoop-yarn
> --------------------------------------------------------------
>
> Key: YARN-3599
> URL: https://issues.apache.org/jira/browse/YARN-3599
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: documentation
> Reporter: Gabor Liptak
> Priority: Trivial
> Attachments: YARN-3599.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
