[ 
https://issues.apache.org/jira/browse/YARN-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535095#comment-14535095
 ] 

Varun Saxena commented on YARN-3489:
------------------------------------

[~leftnoteasy], oh didn't notice that SchedulerUtils is marked as private. We 
can change the current API then because my major concern was changing a public 
API. I will update new patch as per your suggestion then. 

> RMServerUtils.validateResourceRequests should only obtain queue info once
> -------------------------------------------------------------------------
>
>                 Key: YARN-3489
>                 URL: https://issues.apache.org/jira/browse/YARN-3489
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Jason Lowe
>            Assignee: Varun Saxena
>         Attachments: YARN-3489.01.patch, YARN-3489.02.patch
>
>
> Since the label support was added we now get the queue info for each request 
> being validated in SchedulerUtils.validateResourceRequest.  If 
> validateResourceRequests needs to validate a lot of requests at a time (e.g.: 
> large cluster with lots of varied locality in the requests) then it will get 
> the queue info for each request.  Since we build the queue info this 
> generates a lot of unnecessary garbage, as the queue isn't changing between 
> requests.  We should grab the queue info once and pass it down rather than 
> building it again for each request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to